Remove redundant tests for duty with no pre-consensus, consensus, or post-consensus #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Leave just one test
…xit. Leave just one test
|
This pull request has been marked as stale due to 60 days of inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes redundant tests that would test pre-consensus, consensus, or post-consensus messages for duties that don't have one of these duty steps.
Besides removing redundant tests, in order to ensure that duty runners reject messages for steps they don't have, a single test expecting an error was created for each duty step (e.g.
NoPreConsensusPhase).Closes #203