Skip to content

feat: add card deletion during review with confirmation logic and settings#1357

Open
dangxia wants to merge 1 commit intost3v3nmw:masterfrom
dangxia:dev0120
Open

feat: add card deletion during review with confirmation logic and settings#1357
dangxia wants to merge 1 commit intost3v3nmw:masterfrom
dangxia:dev0120

Conversation

@dangxia
Copy link

@dangxia dangxia commented Jan 20, 2026

This PR implements a new feature allowing users to delete cards directly from the Review UI. It includes safety measures to prevent accidental deletions and a global setting to toggle the feature's visibility.

Key Changes

1. UI Enhancements

  • Added a Delete button to the Card UI, positioned to the right of the SKIP button.
  • Integrated the button with the existing theme to ensure visual consistency.

2. Interaction Logic

  • Standard Click: Triggers a confirmation dialog to prevent accidental data loss.
  • Power User Shortcut: Holding Command (Mac) or Ctrl (Windows/Linux) while clicking the Delete button will bypass the confirmation and execute the deletion immediately.

3. Configuration & Settings

  • Introduced a new configuration option: Enable Delete Button.
  • Default State: Set to False (Disabled) to maintain the existing user experience unless explicitly opted-in.

4. Internationalization & Documentation

  • Added i18n strings for the Delete button, confirmation prompts, and settings labels.
  • Updated relevant documentation to reflect the new functionality and keyboard shortcuts.

@KyleKlus KyleKlus self-requested a review February 18, 2026 10:20
@KyleKlus KyleKlus added the enhancement New feature or request label Feb 18, 2026
@KyleKlus
Copy link
Collaborator

KyleKlus commented Feb 18, 2026

Hi, so I had a look at your feature.

I think generally it's a pretty nice feature to have, but I see some difficulties with the current implementation:

1. I think using the default confirm dialog window of the device that one is on, could lead to some difficulties

  • Design wise, I think it would look a bit odd, as every confirm dialog looks different from device to device
  • When it comes to debugging it would be harder to do so, as again every device has a different confirm dialog and one cant check every device to see if the device specific dialog did some odd thing

So I would propose maybe reusing part of the edit dialog to make a delete dialog sort of like this:

New delete card dialog

2 . The power user shortcut could lead to accidental data loss

  • I think it is far too easy to accidentally double click and delete two cards instead of one
  • When one hasn't read the docs, then one doesn't know about the short cut and one could accidentally press it.
  • So I think it is a bit too dangerous to have it in there

3. The delete function leaves some empty lines if one wrote the cards with some empty lines around it

  • I would at least add some more info to the description of the enable toggle, that this can happen
  • Maybe also add that the usage of the button is at ones own risk and will delete the card without being able to restore it
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants