Use baseline mtime instead of current time#188
Open
mwikberg-virta wants to merge 4 commits intostaabm:mainfrom
Open
Use baseline mtime instead of current time#188mwikberg-virta wants to merge 4 commits intostaabm:mainfrom
mwikberg-virta wants to merge 4 commits intostaabm:mainfrom
Conversation
Owner
|
Which problem should this PR solve? Would #91 also work for you? |
Author
|
The problem is that all JSON files got the same (current) date, so the graph is not very useful [
{
"phpstan-baseline.neon": {
"Date": "Fri, 29 Nov 2024 17:01:16 +0000",
"Overall-Errors": 4062,
"Classes-Cognitive-Complexity": 0,
"Deprecations": 44,
"Invalid-Phpdocs": 37,
"Unknown-Types": 3,
"Anonymous-Variables": 0,
"Native-Property-Type-Coverage": 0,
"Native-Param-Type-Coverage": 0,
"Native-Return-Type-Coverage": 0,
"Unused-Symbols": 0
}
}
]versus with the correct dates.. The |
Author
|
At least I guess that the actual modification time of the baseline is more correct than "now" in most cases? It could maybe be optional though... |
Owner
|
did you check whether the fix from #91 would work for you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Added flag
--mtimeto use the baseline file modification timestamp as the date instead of "now", because it makes much more sense when you need to generate multiple reports from the same repository or want to track actual changes to the baseline