Skip to content

feat: support Boho hardfork in genesis generator#64

Merged
0xmhha merged 3 commits intodevfrom
fix/genesis-generator-boho-fork
Mar 30, 2026
Merged

feat: support Boho hardfork in genesis generator#64
0xmhha merged 3 commits intodevfrom
fix/genesis-generator-boho-fork

Conversation

@0xmhha
Copy link
Copy Markdown
Member

@0xmhha 0xmhha commented Mar 19, 2026

Summary

  • Add BohoBlock default (0) to makeGenerator so new genesis configs include Boho activation out of the box
  • Introduce setBohoConfig to configure the Boho hardfork (GovMinter v1 → v2 upgrade)
  • Refactor setAnzeonConfig by extracting setAnzeonConfigBase to separate interactive prompts from core config logic, improving testability
  • Add unit tests covering Boho block number, GovMinter v2 setup, and config isolation

Dependencies

This PR depends on #63 and must be merged after it.

Test plan

  • TestMakeGenerator_BohoBlockDefaultZero — verifies BohoBlock defaults to 0
  • TestSetBohoConfig_OverridesDefaultBlock — verifies user-specified block overrides default
  • TestSetBohoConfig_BlockNumber — table-driven test for various block numbers
  • TestSetBohoConfig_GovMinterV2 — verifies GovMinter address and version
  • TestSetBohoConfig_OnlyContainsGovMinter — ensures Boho config doesn't leak other contracts
  • TestSetAnzeonConfigBase_GovMinterV1 — verifies base config uses v1 and doesn't set Boho

@0xmhha 0xmhha changed the title feat: support Boho hardfork in genesis generator [WIP] feat: support Boho hardfork in genesis generator Mar 19, 2026
@0xmhha 0xmhha marked this pull request as draft March 19, 2026 01:08
@0xmhha 0xmhha self-assigned this Mar 19, 2026
@0xmhha 0xmhha added the enhancement New feature or request label Mar 19, 2026
Comment thread cmd/genesis_generator/genesis_generator.go
Add BohoBlock default in makeGenerator and introduce setBohoConfig
for GovMinter v1 to v2 upgrade. Refactor setAnzeonConfig by extracting
setAnzeonConfigBase to separate interactive prompts from core logic.
Include unit tests for Boho configuration.
@0xmhha 0xmhha force-pushed the fix/genesis-generator-boho-fork branch from 29ca89c to b7dbe33 Compare March 25, 2026 11:27
…at in tests

- Add missing ApplepieBlock to makeGenerator for fork order consistency
- Replace custom stringRepeat helper with strings.Repeat from stdlib
- Remove trailing newline to satisfy gofmt
@0xmhha 0xmhha changed the title [WIP] feat: support Boho hardfork in genesis generator feat: support Boho hardfork in genesis generator Mar 26, 2026
@0xmhha 0xmhha marked this pull request as ready for review March 26, 2026 04:18
@colinkim colinkim self-requested a review March 27, 2026 04:34
Comment thread cmd/genesis_generator/genesis_generator.go Outdated
Set GasLimit to 105000000 to match StableNet network config and remove
ArrowGlacierBlock/GrayGlacierBlock which are not used in StableNet.
Copy link
Copy Markdown
Collaborator

@hominlee-wemade hominlee-wemade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@colinkim colinkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@eomti-wm eomti-wm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xmhha 0xmhha merged commit c388a60 into dev Mar 30, 2026
3 checks passed
@hominlee-wemade hominlee-wemade deleted the fix/genesis-generator-boho-fork branch April 9, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants