feat(terminal): view diff on unsaved file close#1242
Open
shamounY wants to merge 1 commit intostablyai:mainfrom
Open
feat(terminal): view diff on unsaved file close#1242shamounY wants to merge 1 commit intostablyai:mainfrom
shamounY wants to merge 1 commit intostablyai:mainfrom
Conversation
Contributor
|
thx for the PR! @brennanb2025 will review it tmr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a brand-new "View Diff" feature for the unsaved changes prompt when closing a file. Previously, if users had unsaved changes and tried to close a file, they had to either blindly save, discard, or manually cancel to go look at their code again.
Screenshots
With this feature:
DiffEditorcomponent.unsaved-close-queue.ts): We now properly track and dequeue files during bulk closes (like quitting the window or closing all tabs) so you get sequentially prompted for each unsaved file exactly once, avoiding duplicate dialog overlaps.Closes #1237
Testing
pnpm lintpnpm typecheckpnpm testpnpm build