Skip to content

Conversation

@rbavery
Copy link
Collaborator

@rbavery rbavery commented Dec 15, 2025

Description

Updates to pin to the latest torchgeo release or greater instead of a commit. 0.8.0 brings in a lot of new models, features, and update model metadata.

this currently fails due to an unrelated issue with our tests #133

After this is merged, I'd like to make a new minor release 0.5.0 for stac-model.

Related Issue

Type of Change

  • 📚 Examples, docs, tutorials or dependencies update;
  • 🔧 Bug fix (non-breaking change which fixes an issue);
  • 🥂 Improvement (non-breaking change which improves an existing feature);
  • 🚀 New feature (non-breaking change which adds functionality);
  • 💥 Breaking change (fix or feature that would cause existing functionality to change);
  • 🔐 Security fix.

Checklist

  • I've read the CONTRIBUTING.md guide;
  • I've updated the CHANGELOG.md with provided changes;
  • I've updated the README.md and/or best-practices.md as applicable with new features;
  • I've updated the code style using make check;
  • I've written tests for all new methods and classes that I created;
  • I've written the docstring in Google format for all the methods and classes that I used.

@rbavery rbavery requested a review from fmigneault December 15, 2025 21:43
Copy link
Collaborator

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since UNet is officially included, does that affect any of the examples that attempts loading the definition from torch definitions?

mlm/stac_model/examples.py

Lines 250 to 255 in 41a2cef

from torchgeo.models import Unet_Weights, unet
# Set the STAC version to 1.0.0 for compatibility with the example using relative links
pystac.set_stac_version("1.0.0")
weights = Unet_Weights.SENTINEL2_2CLASS_NC_FTW
model = unet(weights=weights)

mlm/stac_model/examples.py

Lines 284 to 294 in 41a2cef

item_ext = MLModelExtension.from_torch(
model,
task=task,
weights=weights,
item_id=item_id,
collection=collection_id,
bbox=bbox,
geometry=geometry,
datetime_range=datetime_range,
stac_properties=properties,
)

After this is merged, I'd like to make a new minor release 0.5.0 for stac-model.

Yes, but #133 should also be fixed. The releases should at least succeed at the point in time they were built.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants