feat: V2 links updates#1693
Merged
ircwaves merged 12 commits intostac-utils:v2from Apr 27, 2026
Merged
Conversation
23 tasks
ircwaves
force-pushed
the
v2-links-updates-pt1
branch
from
72eed09 to
b6aab34
Compare
ircwaves
force-pushed
the
v2-links-updates-pt1
branch
from
060d2f5 to
f62e8ab
Compare
jsignell
reviewed
Apr 22, 2026
clone get_absolute_href (reconsider this) target.setter (deprecated w/ warning) collection, self, child, item, derived_from, and canonical
ircwaves
force-pushed
the
v2-links-updates-pt1
branch
from
f62e8ab to
a2ebb38
Compare
jsignell
reviewed
Apr 22, 2026
| mime_type = "example/stac_thing" | ||
| link = pystac.Link(rel, target, mime_type, "a title", extra_fields={"a": "b"}) | ||
| link = pystac.Link( | ||
| rel, target, media_type=mime_type, title="a title", extra_fields={"a": "b"} |
Member
There was a problem hiding this comment.
I think we should look for extra_fields in init kwargs and if they are in there, raise a warning, but use them to update kwargs. It would be a surprising change to have extra_fields show up in the dict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Container.get_itemLink.cloneviadeepcopyLink.targetsetter with deprecation noticeLink.get_absolute_href, as it was needed for some v1 testsLink.resolve_stac_objectchild, collection, item, derived_from)Description:
PR Checklist:
pre-commit run --all-files)pytest)