Fix BaseSettings import for pydantic v2 (use pydantic.v1 fallback)#281
Open
yugo-kato wants to merge 1 commit intostac-utils:mainfrom
Open
Fix BaseSettings import for pydantic v2 (use pydantic.v1 fallback)#281yugo-kato wants to merge 1 commit intostac-utils:mainfrom
yugo-kato wants to merge 1 commit intostac-utils:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores compatibility with Pydantic v2 for the bundled
planetary_computersettings module by using a small import shim forBaseSettings.QGIS environments can end up with
pydantic>=2, whereBaseSettingswas moved out ofpydantic(topydantic-settings). This can prevent the plugin from loading with:Related: #261
What changed
BaseSettingsfrompydantic.v1when available (Pydantic v2), otherwise fall back topydantic(Pydantic v1).Settingsto inherit from the importedBaseSettingsinstead ofpydantic.BaseSettings.This keeps the plugin working across both Pydantic v1 and v2 without forcing users to install additional packages in constrained QGIS Python setups.
Why this approach
pydantic.v1, which allows v1-styleBaseSettingsusage.pydantic-settingsin environments where adding Python dependencies is difficult (common for QGIS plugin users).How to reproduce (before)
pydantic>=2is present.PydanticImportErrorcomplaining aboutBaseSettings.Note: This change was drafted with assistance from ChatGPT Codex and reviewed/validated by the author.