Skip to content

Fix Search model to make sure _start_date and _end_date privateAttr are cleared on model initialization #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2025
Merged

Fix Search model to make sure _start_date and _end_date privateAttr are cleared on model initialization #172

merged 2 commits into from
Feb 28, 2025

Conversation

vincentsarago
Copy link
Member

second take at #171

@vincentsarago
Fix Search model to make sure _start_date and _end_date private…
8a6a4b8 
…Attr are cleared on model initialization
@vincentsarago
Copy link
Member Author

@sbrunato I've taken a slightly different approach. Would love to have your opinion

🙏

@vincentsarago vincentsarago mentioned this pull request Feb 25, 2025
Closed
@sbrunato
Copy link

@sbrunato I've taken a slightly different approach. Would love to have your opinion

🙏

I prefer this approach, using pydantic ValidationInfo and after-validation! Nice 👍

@vincentsarago vincentsarago merged commit cfb417b into main Feb 28, 2025
6 checks passed
@vincentsarago vincentsarago deleted the patch/clear-datetime-privateAttr branch February 28, 2025 14:42
@vincentsarago vincentsarago mentioned this pull request Feb 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentsarago @sbrunato