Skip to content

Conversation

@Lethe10137
Copy link
Member

Rebase #145 to #150.

@BobAnkh BobAnkh force-pushed the pktlog_converter branch 4 times, most recently from def9000 to 9751584 Compare December 15, 2025 13:31
Base automatically changed from pktlog_converter to main December 15, 2025 14:16
@BobAnkh
Copy link
Member

BobAnkh commented Dec 16, 2025

@Lethe10137 Please rebase the PR first. Ping me when it is ready for review

@Lethe10137
Copy link
Member Author

Lethe10137 commented Dec 17, 2025

tput_comparsion

By modifying the Delay cell, the recent commit (3fb0ac3) has (slightly) better tput than current main branch.

@Lethe10137 Lethe10137 marked this pull request as ready for review December 19, 2025 16:28
@Lethe10137 Lethe10137 requested a review from BobAnkh December 19, 2025 16:28
@BobAnkh
Copy link
Member

BobAnkh commented Jan 13, 2026

@Lethe10137 cargo-audit fails, which means your new depencency have security vulnerability, please check which depencency use this.

Copy link
Member

@BobAnkh BobAnkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't clearly checked the TBF's implementation, but let's first discuss the bandwidth cell. Let's decide how to define our logic and physical meaning of next_available together with the timestamp on the packet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may need further discussion on how to set the current time for a packet within bandwidth-like cells. Given that we currently send packets at next_available, but they only arrive after next_available + transfer_time, should we update the packet's timestamp to next_available + transfer_time? In the current implementation (including previous versions), our packets are expected to arrive at the next cell at the time of next_available. I believe there may be design flaws in our previous approach. We may need some further discussion with @Lethe10137 and @Centaurus99

@BobAnkh
Copy link
Member

BobAnkh commented Jan 13, 2026

Please review the bandwidth cell only, @Centaurus99

@Lethe10137
Copy link
Member Author

@Lethe10137 cargo-audit fails, which means your new depencency have security vulnerability, please check which depencency use this.

mnl is a direct dependency of rattan, introduced when the nat feature was implemented.

@BobAnkh
Copy link
Member

BobAnkh commented Jan 14, 2026

@Lethe10137 cargo-audit fails, which means your new depencency have security vulnerability, please check which depencency use this.

mnl is a direct dependency of rattan, introduced when the nat feature was implemented.

@Centaurus99 Please check it, as nat is implemented by you.

@Lethe10137
Copy link
Member Author

tput_comparsion_260115 The tput performance of current PR, 5d9b158, is slightly better than the main branch.

@BobAnkh
Copy link
Member

BobAnkh commented Jan 15, 2026

@Lethe10137 Is everything ready for review again?

@Lethe10137 Lethe10137 requested a review from BobAnkh January 15, 2026 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants