chore(stackable-telemetry)!: Bump OpenTelemetry related dependencies #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also adjust the code based on the many breaking changes between the old and new versions of the crates. The public API is not affected by these changes.
Due to the dependency bumps in the previous commit, this function can no longer be maintained due to the underlying libraries being incompatible. It is recommended to use stackable_telemetry as the replacement.
Due to initialize_logging being removed and being replaced by stackable_telemetry, the CLI interface needs to be adjusted as well. The old --tracing-target argument is removed in favour of more granular arguments to enable different outputs and exporters.
Techassi
force-pushed
the
chore/opentelemetry-bumps
branch
from
1edd66b to
413833c
Compare
Techassi
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#639
Caution
The CLI design is not finalized and this PR will be merged and released after #950 is released.
This PR bumps OpenTelemetry related dependencies and adjusts the code accordingly. It also removes the
initialize_logginghelper function due it being no longer maintainable because of incompatibilities in the underlying libraries.Additionally, the CLI interface is adjusted to include more granular arguments (and env variables) which enable different outputs and exporters for telemetry data.
These changes were tested using the dummy-webhook and the observability stack.