Closed
Conversation
Collaborator
|
Since the notify function isn't a performance hotspot, I think keeping the Surface API code simple and easier for people to understand will have a greater benefit. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
946.52 ns/iter921.31 ns951.22 ns967.06 ns972.19 ns4.09 µs/iter4.03 µs4.09 µs4.30 µs4.30 µs34.57 µs/iter34.18 µs34.63 µs34.66 µs34.86 µs7.20 µs/iter7.19 µs7.22 µs7.22 µs7.23 µs38.08 µs/iter37.57 µs38.21 µs38.25 µs38.26 µs346.01 µs/iter321.71 µs347.13 µs368.67 µs467.71 µs69.05 µs/iter63.63 µs68.46 µs83.42 µs89.92 µs384.42 µs/iter359.38 µs385.75 µs416.67 µs428.29 µs3.44 ms/iter3.41 ms3.44 ms3.48 ms3.49 msAfter:
948.87 ns/iter930.30 ns952.74 ns974.88 ns977.20 ns4.07 µs/iter4.03 µs4.08 µs4.11 µs4.12 µs34.46 µs/iter34.25 µs34.55 µs34.66 µs34.73 µs7.24 µs/iter7.20 µs7.25 µs7.27 µs7.28 µs38.07 µs/iter37.98 µs38.12 µs38.14 µs38.18 µs345.86 µs/iter322.67 µs346.63 µs364.63 µs491.71 µs69.11 µs/iter63.96 µs69.08 µs76.96 µs102.71 µs381.57 µs/iter356.21 µs382.00 µs399.13 µs418.54 µs3.42 ms/iter3.39 ms3.43 ms3.46 ms3.48 msThe performance change is minimal, because the error of each device run needs to be taken into account, so it is concluded that this has no impact on performance. But it will be slightly better if there are many nodes. (Still negligible)
In terms of memory usage,
treehas been reduced.