ci(GHC): Drop GHC version 8 and add 9.6, 9.8, 9.10 as supported #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidnbr
force-pushed
the
db/bump_ghc_version_support
branch
from
96f6062 to
76959ae
Compare
sestrella
reviewed
Apr 17, 2025
sestrella
reviewed
Apr 17, 2025
davidnbr
changed the title
sestrella
reviewed
Apr 24, 2025
sestrella
reviewed
Apr 24, 2025
DavidMazarro
dismissed
their stale review
I didn't realize the version bumped was a major one
DavidMazarro
reviewed
May 9, 2025
There was a problem hiding this comment.
I left a comment about the version bump. Also, maybe you want to add the latest GHC version (9.12.1) as part of the tests, as suggested by @jpvillaisaza and @sestrella in Slack?
1.1.1) bump: add GHC version 9.12.2 as supported
sestrella
reviewed
May 9, 2025
| @@ -375,7 +377,7 @@ instance ToJSON Notifier where | |||
| defaultNotifier :: Notifier | |||
| defaultNotifier = Notifier | |||
| { notifierName = "rollbar-client" | |||
| , notifierVersion = "1.1.0" | |||
| , notifierVersion = T.pack (showVersion Paths.version) | |||
sestrella
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.