Perpetual Edit #1915
Perpetual Edit #1915
Conversation
Soxasora
force-pushed
the
perpetual_edit
branch
3 times, most recently
from
3fa0464 to
5544450
Compare
…ed; don't record bios
Soxasora
force-pushed
the
perpetual_edit
branch
from
5544450 to
db1838b
Compare
Soxasora
force-pushed
the
perpetual_edit
branch
from
9925a18 to
0a6bcb6
Compare
Soxasora
force-pushed
the
perpetual_edit
branch
from
2cbc55b to
f219eba
Compare
api/paidAction/itemUpdate.js
Outdated
| // history tracking | ||
| // has to be older than 10 minutes, not a bio, not a job, not deleted, not a special item. | ||
| const adminItem = ADMIN_ITEMS.includes(old.id) | ||
| if (old.createdAt < new Date(Date.now() - 10 * 60 * 1000) && !old.bio && old.subName !== 'jobs' && !data.deletedAt && !adminItem) { | ||
| await tx.oldItem.create({ | ||
| data: { | ||
| title: old.title, | ||
| text: old.text, | ||
| url: old.url, | ||
| userId: old.userId, | ||
| subName: old.subName, | ||
| imgproxyUrls: old.imgproxyUrls, | ||
| cloneBornAt: old.cloneBornAt, | ||
| cloneDiedAt: new Date(), | ||
| originalItemId: parseInt(id) | ||
| } | ||
| }) | ||
|
|
||
| data.cloneBornAt = new Date() // we can use this to determine if the item has been edited | ||
| data.cloneDiedAt = null | ||
| } | ||
|
|
There was a problem hiding this comment.
Since we really just want to track Item content editing, I switched to a Prisma-based version of the trigger that I think it's more appropriate. Before, every update to Item could fire the procedure and confront the conditions.
Also on this, not having Item inheritance made me think that having just enough columns can be okay, but also having the whole item is okay to me, maybe future-proof
|
The non-trigger-based versioning, and of only select fields, makes me a little nervous tbh. I haven't looked at it very carefully at it though. I'll try to take a closer look when I'm less tired. |
|
Reverting to trigger is something I was debating myself some days ago, I just want to do it better than what it was before switching to Prisma. I think we can do a 1:1 copy of Item for OldItem! I was selecting just the bare minimum for it to be displayed. Thanks k00b, redrafting! ^^ |
Description
Completes #1049
Enables perpetual editing with history accessible with
oldVersions(references OldItem) on Item.What we want is to guarantee an Item's immutability by storing the original Item before editing. Allowing us to see and compare the editing history.
But, before immutability and history making, we have shadow editing: a 10 minutes period of grace where the user can edit however and how much they want without ever creating a record of it, using the same mechanism every stacker is already used to.
Screenshots
Early UI
Item info, history:
Old Item:
Old Item with image:
Additional Context
The goal was to achieve this via Postgres' polymorphism but Prisma doesn't support inheritance and at the moment we store what really can be changed via editing, which is the content (title, text, url).
We can pivot from Shadow Editing by removing references to it.
We don't record to OldItem if it's a biography (shadow editing).
Design goal
Checklist
Are your changes backwards compatible? Please answer below:
Yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
7.5: more details
OKcommentsOKitems that belongs to a territoryOKpinned items that belongs to a territoryOKonly the author can editOKshadow editingOKitem historyOKold item readability, markdown and imagesOKrecord only after 10 minutes and if content has changedOKdon't record history on bios, jobs, itemsFor frontend changes: Tested on mobile, light and dark mode? Please answer below:
Yes!
Did you introduce any new environment variables? If so, call them out explicitly here:
No
Progress