Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: Email addresses should be case insensitive #1923

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

Soxasora
Copy link
Member

@Soxasora Soxasora commented Feb 23, 2025

Description

Emails are stored in lower-case and the verification is case-sensitive.
This PR converts the email address saved in session storage to lower case at the time of callbackUrl building, preventing unexpected login errors.

Screenshots

Additional Context

Code-entering page displays the email inserted by the user as-is to maintain the email as expected by the user, this fix operates behind the scenes

Checklist

Are your changes backwards compatible? Please answer below:
Yes

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
7, inserted all types of emails, as long as the email is correct whether UPPERCASE or lowercase it can't give an error.

For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a

Did you introduce any new environment variables? If so, call them out explicitly here:
No

@huumn huumn merged commit 7b988b8 into stackernews:master Feb 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants