Safari media enhancements #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applies a workaround for Safari's poor handling of
block: revert-layerby declaring a minimum width, acting as a fallback for size miscalculation during re-rendering.Removes
overflow: hiddenfrom mediaContainer as Safari was probably calculating its area of effect based on wrong aspect-ratio during loading.Reverts #1886 per above
Screenshots
Testing in production
L: response local override on prod
R: unmodified prod
fix: Video disappearing or not showing1
Screen.Recording.2025-03-02.at.18.52.30.mp4
fix: Image clipping or not showing
Screen.Recording.2025-03-02.at.19.05.46.mp4
Additional Context
Drafting a bit to test more, avoiding flukes
Even if next Safari versions will permanently fix problems related to
object-fit: containandblock: revert-layer, which we use, a workaround is needed for the time being as adoption rate is historically really slow.Checklist
Are your changes backwards compatible? Please answer below:
Yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
6.5, tested for hours on prod, still testing
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
n/a
Footnotes
The black screen on full screen is related to my system performances in that moment ↩