Fix footnotes and overflow #1940
Merged
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you click on a footnote in a long post before you click
show full text, the button disappears but the text is still contained:2025-03-03.13-57-18.mp4
However, this also happens if you clicked
show full text. In that case, the text is contained again.Steps to reproduce
Additional Context
The fix is to remove code that was added in cc4bbf9 and explicitly checks for the
#itemfn-prefix. This looks like the code was added to fix something. But I couldn't tell what that would be. Why wouldn't we want to show the full text if we're navigating to a footnote? Wouldn't we want to handle it like clicking on a chapter? 🤔Checklist
Are your changes backwards compatible? Please answer below:
yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
7. Tested clicking on footnotes, chapters, hard navigation, shallow navigation.For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
no