Also check for user
before setting multi auth cookies
#1941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #1904, I noticed checking
req && res
to detect if it's a login is weird. Not sure why I did that sincenext-auth
already gives us a way to detect logins:-- https://next-auth.js.org/configuration/callbacks#jwt-callback
So I moved the code into the existing
if (user)
block and tested that we can still:Authentication is critical piece of code so to keep the
if (req && res)
check might make sense butreq
is definitely set (we also access it above) so I only addedif (res)
.res
should also always be set ... but only afaict.Update
Changed my mind regarding this PR, see #1941 (comment)