fix: Push registration evaluation errors and improve Brave UX #1947
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecific push registration error and guidance; Remove unused fetch debug plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1945
Exposes env-dependent constant to service worker through
next.config.js.Removes unused debug
fetchDidFailfrom service worker that was causing evaluation errors when browsers can't fetch the related resources as it was trying to access inaccessible-from-swprocess.Fixing evaluation errors that prevented Push registration.
Also adds Brave Browser-specific error to guide users in enabling "Use Google services for push messaging", when disabled we cannot do Push registration.
Screenshots
Additional Context
Brave's failure in push registration because of its settings also highlighted other errors that also prevented new service worker registrations on other browsers.
Checklist
Are your changes backwards compatible? Please answer below:
Yes, old registrations still works, failed registrations will automatically try again after updating the service worker.
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
6, tested on Brave, Chrome, Safari.
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
No, exposed a constant based on an env var to sw