Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no pw manager autofill for device sync password #1953

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ekzyis
Copy link
Member

@ekzyis ekzyis commented Mar 7, 2025

Description

fix #1950

I think that we use <textarea> instead of <input> is related, see video.

I tried yesterday to get my password manager autofill to work with <textarea>, which is what we currently use for the device sync password input, but I am not sure it's possible even though it has autocomplete="current-password" and type="password" set. So I think we need to switch to <input>.

Video

2025-03-07.14-16-08.mp4

Additional Context

Password manager autofill is also related to us wanting to switch to a dedicated input component for bip39 with separate inputs for each word: I guess with separate inputs you can't use password manager autofill 🤔

edit: or maybe it could work by using autofill on the first word input and then our code puts each word into its own input by splitting on whitespace 🤔

Checklist

Are your changes backwards compatible? Please answer below:

yes

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:

7. See video.

For frontend changes: Tested on mobile, light and dark mode? Please answer below:

n/a

Did you introduce any new environment variables? If so, call them out explicitly here:

no

@Soxasora
Copy link
Member

Soxasora commented Mar 7, 2025

Password manager autofill is also related to us wanting to switch to a dedicated input component for bip39 with separate inputs for each word: I guess with separate inputs you can't use password manager autofill 🤔
edit: or maybe it could work by using autofill on the first word input and then our code puts each word into its own input by splitting on whitespace 🤔

For quite a bit of time I wanted to adjust MultiInput to effortlessly support also device sync, atm it supports autofill (with proper adjustments?) the way you envisioned it as it switches inputs once it reaches eg. 6 characters ^^

edit: but yeah we would need to exclude whitespaces onPaste for it to work

@ekzyis
Copy link
Member Author

ekzyis commented Mar 7, 2025

I'll check if we can keep the textarea functionality where it wraps to the next line instead of horizontal scroll

update: mhh, doesn't seem to be possible, that's what <textarea> is for

@ekzyis ekzyis marked this pull request as draft March 7, 2025 21:44
@ekzyis ekzyis marked this pull request as ready for review March 7, 2025 21:55
@ekzyis ekzyis force-pushed the device-sync-pw-manager-autofill branch from 1fd3a30 to 3eb6fbd Compare March 7, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device Sync does not use password text bot on mobile
2 participants