Fix no pw manager autofill for device sync password #1953
+0
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #1950
I think that we use
<textarea>
instead of<input>
is related, see video.I tried yesterday to get my password manager autofill to work with
<textarea>
, which is what we currently use for the device sync password input, but I am not sure it's possible even though it hasautocomplete="current-password"
andtype="password"
set. So I think we need to switch to<input>
.Video
2025-03-07.14-16-08.mp4
Additional Context
Password manager autofill is also related to us wanting to switch to a dedicated input component for bip39 with separate inputs for each word: I guess with separate inputs you can't use password manager autofill 🤔
edit: or maybe it could work by using autofill on the first word input and then our code puts each word into its own input by splitting on whitespace 🤔
Checklist
Are your changes backwards compatible? Please answer below:
yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
7
. See video.For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
no