Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any admin to toggle SNL banner #1955

Merged
merged 1 commit into from
Mar 8, 2025
Merged

Allow any admin to toggle SNL banner #1955

merged 1 commit into from
Mar 8, 2025

Conversation

ekzyis
Copy link
Member

@ekzyis ekzyis commented Mar 7, 2025

I thought @huumn forgot to enable the SNL banner but I just had to refresh my page.

I think this is still a good idea.

QA: 9. Tested that non-admins cannot toggle and tested that admins can with this patch and inserting a row into the Snl table:

diff --git a/lib/constants.js b/lib/constants.js
index a2feb4df..d904b291 100644
--- a/lib/constants.js
+++ b/lib/constants.js
@@ -62,9 +62,10 @@ export const USER_ID = {
   anon: 27,
   ad: 9,
   delete: 106,
-  saloon: 17226
+  saloon: 17226,
+  test01: 21858
 }
-export const SN_ADMIN_IDS = [USER_ID.k00b, USER_ID.ek, USER_ID.sn]
+export const SN_ADMIN_IDS = [USER_ID.k00b, USER_ID.ek, USER_ID.sn, USER_ID.test01]
 export const SN_NO_REWARDS_IDS = [USER_ID.anon, USER_ID.sn, USER_ID.saloon]
 export const MAX_POLL_NUM_CHOICES = 10
 export const MIN_POLL_NUM_CHOICES = 2

@ekzyis ekzyis force-pushed the live-allow-any-admin branch from c637b6d to 5cfda06 Compare March 7, 2025 22:34
@huumn huumn merged commit 5b7ff24 into master Mar 8, 2025
6 checks passed
@huumn huumn deleted the live-allow-any-admin branch March 8, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants