System logger for users #2035
Open
System logger for users #2035
+30
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekzyis
force-pushed
the
system-logger
branch
2 times, most recently
from
385cf48 to
0514f91
Compare
1 task
ekzyis
commented
Mar 27, 2025
|
|
||
| export default async ({ query: { username, amount, nostr, comment, payerdata: payerData }, headers }, res) => { | ||
| const user = await models.user.findUnique({ where: { name: username } }) | ||
| if (!user) { | ||
| return res.status(400).json({ status: 'ERROR', reason: `user @${username} does not exist` }) | ||
| } | ||
|
|
||
| const logger = walletLogger({ models, me: user }) | ||
| logger.info('LNURL-pay callback', { amount: formatMsats(amount), nostr, comment }) |
There was a problem hiding this comment.
"LNURL-pay" might still be confusing but it's better than "lnurlp" imo.
Most stackers are probably the most familiar with the concept of a lightning address, but not sure how to mention that here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently can only create wallet logs linked to a specific wallet. This means that if we have a user id but no wallet yet, we can't create a log message.
This PR fixes that by dropping the
NOT NULLconstraint on theWalletLog.walletcolumn and by defaulting to "system" for the wallet name in /wallet/logs if we didn't pass in a wallet to the logger call.Checklist
Are your changes backwards compatible? Please answer below:
yes, old logs will continue to work.
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
7. Tested successful p2p zaps with anon as sender, receiver fallbacks, fallback from proxy to direct and ofc generating and paying invoices via lightning address.For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
no