Skip to content

fix duplicate search highlights #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

abhiShandy
Copy link
Member

Description

A clear and concise description of what you changed and why.

fixes #2181

Avoid including both exact matches and item text in search results.

Screenshots

Before
before

After
after

Additional Context

Was anything unclear during your work on this PR? Anything we should definitely take a closer look at?

Checklist

Are your changes backwards compatible? Please answer below:
Yes

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
10

For frontend changes: Tested on mobile, light and dark mode? Please answer below:
Tested on laptop only

Did you introduce any new environment variables? If so, call them out explicitly here:
No

Copy link
Member

@ekzyis ekzyis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to fix duplicate search highlights makes sense to me, but I didn't test

@abhiShandy abhiShandy requested a review from huumn June 5, 2025 18:56
@abhiShandy abhiShandy force-pushed the fix-duplicate-highlight branch from 8427cf0 to b2ea8e9 Compare June 8, 2025 01:42
@huumn huumn merged commit 79d3eb4 into stackernews:master Jun 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search highlights are duplicated
3 participants