-
-
Notifications
You must be signed in to change notification settings - Fork 130
Nostr Cross Posting Delay #2206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
added info tooltip for LNURL-auth button
Update LNURL-UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not passing linting. run sndev lint
to see errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You cannot zap after auth'ing from lightning. its just auth .............
checked. fixed the errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how can that be there is |
removed extra padding
this should do |
Can you post screenshots like mentioned in the PR template? |
i wanted to but i could not. |
You weren't able to run the code? |
no. my pc doesn't support docker, and codespaces doesn't open the ports idk why |
How do you explain your
|
through dev console, i edited the code live |
That doesn't mean you tested your code which is what QA means ... |
if it was wrong, it would not have showed up on the page right? |
is this fine? symmetrical padding on both sides and centered info button? |
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very sorry for 2 PRs in one but Github does not let commit 2 pull requests from 1 branch and I had changed the master branch itself
Create another branch.
using user's nostrPubkey now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you read AND understand this comment?
Description
Closes #2194
This PR implements delayed crossposting from Stacker News (SN) to Nostr. When a user creates a post and selects "crosspost to Nostr," the post is not immediately sent to Nostr. Instead, the backend schedules the crosspost to occur 10 minutes after creation, allowing the user to edit the post within that window. Only the final version after 10 minutes is sent to Nostr.
What I changed and Why:
crosspost
flag to the backend.Code references:
pendingNostrCrosspost
andnostrCrosspostAt
fields to theItem
model.Screenshots
update
Additional Context
package.json
orpackage-lock.json
.Additional Context
use-item-submit.test.js
(already removed)nostrCrosspost.test.js
nostr.js
The entire
__tests__
and__mocks__
foldersNo related packages or dependencies remain in package.json or package-lock.json.
Checklist
Are your changes backwards compatible? Please answer below:
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
Did you introduce any new environment variables? If so, call them out explicitly here: