user and territory autocomplete in search bar #2217
+94
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huumn
approved these changes
Jun 10, 2025
There was a problem hiding this comment.
This works well. Nice job.
However, this change suggests an opportunity for generalization. Both MarkdownInput and this new SearchInput share an awful lot of logic that can probably be abstracted into a SuggestionInput component and/or a hook that they share.
It's beyond the scope of the PR perhaps, so I'll try to do this myself soon.
|
Makes sense. I also noticed the opportunity for generalization, but didn't want to mess with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2039
Implements autocomplete in the search bar. Functionality should work the same as for posts.
@brings up a list of users and~brings up a list of territories.Screenshots
autocomplete-search.mov
Additional Context
n/a
Checklist
Are your changes backwards compatible? Please answer below:
yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
8
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
Haven't tested on mobile
Did you introduce any new environment variables? If so, call them out explicitly here:
no