Skip to content

Extract DCR resolver into pkg/auth/dcr#5198

Merged
tgrunnagle merged 4 commits into
mainfrom
dcr-4a_issue_5145
May 12, 2026
Merged

Extract DCR resolver into pkg/auth/dcr#5198
tgrunnagle merged 4 commits into
mainfrom
dcr-4a_issue_5145

Make DCR consume helpers value-in / value-out

cf6e17c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 12, 2026 in 0s

68.17% (+0.25%) compared to 9211a36

View this Pull Request on Codecov

68.17% (+0.25%) compared to 9211a36

Details

Codecov Report

❌ Patch coverage is 71.42857% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.17%. Comparing base (9211a36) to head (cf6e17c).
⚠️ Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
pkg/auth/dcr/resolver.go 72.50% 8 Missing and 3 partials ⚠️
pkg/auth/dcr/store.go 75.00% 1 Missing and 1 partial ⚠️
pkg/authserver/runner/embeddedauthserver.go 71.42% 1 Missing and 1 partial ⚠️
pkg/authserver/server/handlers/dcr.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5198      +/-   ##
==========================================
+ Coverage   67.91%   68.17%   +0.25%     
==========================================
  Files         610      618       +8     
  Lines       62522    63146     +624     
==========================================
+ Hits        42464    43049     +585     
- Misses      16879    16885       +6     
- Partials     3179     3212      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.