Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: Unify required go version and deps #255

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

vikin91
Copy link
Contributor

@vikin91 vikin91 commented Jan 29, 2025

Integration tests were using different versions than the main branch. This PR brings them in par.
The major change is a requirement of go 1.22 it all go.mod files.

@vikin91 vikin91 requested review from RTann and a team as code owners January 29, 2025 09:44

require (
github.com/stretchr/testify v1.10.0
golang.org/x/net v0.34.0
golang.stackrox.io/grpc-http1 v0.0.0+incompatible
golang.stackrox.io/grpc-http1 v0.0.0-00010101000000-000000000000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh weird is there no more +incompatible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used only go get commands to get to that point. Maybe change from go 1.21 to go 1.22 in go.mod also "upgraded" the format in this file? 🤔

@vikin91 vikin91 merged commit bcc66ed into main Jan 30, 2025
2 checks passed
@vikin91 vikin91 deleted the fix/integration-tests-go-version branch January 30, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants