Android: Use dynamic screen-based padding again for navigation camera #885
Merged
ianthetechie merged 3 commits intoMay 27, 2026
Merged
Conversation
…up to maplibre-compose migration stadiamaps#853)
Archdoog
approved these changes
May 5, 2026
Archdoog
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Will let @ianthetechie decide how he wants to get all this merged 👍
…ion-camera-padding
Contributor
Author
|
Conflicts are resolved now. |
Contributor
|
Looks good; thanks! Probably worth a follow-up at some point to automatically take the navigation use case into account (e.g. bike vs pedestrian vs car). We have a somewhat badly named issue #196 that hints at a broader project of optimizing the display per use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the maplibre-compose migration (#853) relative values (0.5) for padding were replaced with hard coded Dp value. I changed this to relative values again.
It could be observed in these screen captures for example, that the 3D navigation puck is too far away from the bottom elements (before and after migration).
Changes
Updates the Android MapLibre navigation camera padding to use dynamic, screen-based values again instead of fixed
Dpoffsets introduced during the maplibre-compose migration.