Replace Material Icons with custom drawable resources#908
Merged
Conversation
Replace all androidx.compose.material.icons usages with manually-added vector drawables and drop the material-icons-extended dependency (which also transitively pulled material-icons-core). Per Google's guidance this cuts build times and bundle size; the project uses material3, which does not bundle the icons packages. Shared control icons (add, remove, navigation, route, volume mute/up, plus new close and keyboard_arrow_up) now live in the ui-shared module so both ui-compose and car-app consume a single copy; the six icons previously duplicated in car-app are moved there and InterfaceCarIcons now resolves them from ui-shared. The demo-app-only my_location icon stays in demo-app. Icons are rendered via painterResource + Icon(tint = ...), matching the existing ManeuverImage pattern. New drawables use Material Symbols to match the icons car-app already shipped. Note: paparazzi snapshots for NavigationUIButtonTest, NavigatingInnerGridViewTest and TripProgressViewTest (exit variant) must be re-recorded (just record-android-snapshots) since the rendered glyphs change. https://claude.ai/code/session_012TeDMkp8aF2XywjsNZR6H4
Archdoog
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the codebase from using Material Design icons (
androidx.compose.material.icons) to custom SVG drawable resources. This removes the dependency on the Material Icons Extended library and centralizes icon management in theui-sharedmodule.Key Changes
androidx.compose.material.icon.extendedfrom build configurations indemo-appandui-composemodulesNavigatingInnerGridView: Navigation, Route, Volume Up/Mute iconsNavigationUIButton: Close iconNavigationUIZoomButton: Add/Remove (zoom) iconsManeuverInstructionView: Info and Build placeholder iconsTripProgressView: Close iconPillDragHandle: Keyboard arrow up iconNotNavigatingOverlay: My Location iconNavigationUIButtonTest: Updated test snapshotsui-shared/src/main/res/drawable/:navigation_24px.xmlroute_24px.xmlvolume_up_24px.xmlvolume_mute_24px.xmladd_24px.xmlremove_24px.xmlclose_24px.xmlkeyboard_arrow_up_24px.xmlmy_location_24px.xmlfor the location buttonIcons.*topainterResource(SharedR.drawable.*)pattern throughoutInterfaceCarIcons.ktto referenceui-sharedresources instead of car-app resourcesImplementation Details
colorControlNormaltint)painterResource()with proper resource imports from the shared modulehttps://claude.ai/code/session_012TeDMkp8aF2XywjsNZR6H4
Fixes #907.