Skip to content

Fix session recording format drift#943

Open
ianthetechie wants to merge 3 commits into
mainfrom
fix-session-recording-format-drift
Open

Fix session recording format drift#943
ianthetechie wants to merge 3 commits into
mainfrom
fix-session-recording-format-drift

Conversation

@ianthetechie

Copy link
Copy Markdown
Contributor

A user reported an issue with replaying a session recording from mobile on the web. It turns out that the JavaScript side was dumping in camelCase but native was doing snake_case. And as a complicating factor, native used a different timestamp format. I'm not sure how we missed that one...

This PR fixes that, and then some:

  • Standardizes on camelCase (gotta pick something, and this ended up being a larger snapshot diff but smaller code diff).
  • Accepts both casings as a temporary measure. I plan to drop this as part of the 1.0 release.
  • Adds our first real web tests!
  • Surfaces errors rather than panicking (this was just something we missed in the post-GSoC cleanup). The APIs now return results, and the web debugger displays the actual error clearly (it was just an incomprehensible wasm crash prior).
Pasted Graphic

@ianthetechie
ianthetechie requested a review from Archdoog July 14, 2026 07:19

@Archdoog Archdoog left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go over the snapshot changes over the call. Generally speaking though, looks fine 👍

@louim

louim commented Jul 24, 2026

Copy link
Copy Markdown

I also hit this while testing the replay and had to temporarily work around it by rejigging the replay json to match the camelCase the web replay tool expected. It's nice to see this fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants