Skip to content

Conversation

@stadlmax
Copy link
Owner

@stadlmax stadlmax commented May 28, 2024

  • support for stock splits
  • support for automated AWV reporting
  • use decimal.Decimal for a more robust handling of floating point numbers
  • round sales proceeds as Schwab seems to do so for sub-cent values
  • introduce new format for transactions, separating RSUs and ESPPs to e.g. allow automated reporting for AWV purposes or to allow a more generic treatment of currency conversions

stadlmax added 2 commits May 31, 2024 17:49
…ting share and forex queues, adapt transaction files to distinguish different events better, prepare transaction files for automated bundesbank reporting
@stadlmax stadlmax changed the title add support for stock splits overhaul: add support for stock splits and automated awv reporting Jun 1, 2024
Copy link
Contributor

@szotsaki szotsaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the before-after comparison and they were equal. So far I couldn't check the foreign currency tab because of the account fill-up workaround

Copy link
Contributor

@szotsaki szotsaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more round of automatic checks :)

@szotsaki
Copy link
Contributor

#10 passes all tests now, let's get everything ready to merge! :)

@stadlmax
Copy link
Owner Author

Great news, would you mind going over the conversations to see if there is still a comment not addressed? I'll do the same :)

Copy link
Contributor

@szotsaki szotsaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some bugfixes and additions in my branch. They start at commit "Make "Anlage SO - Fremdwährungen" summary more precise".

Could you please look at them? After the fixes I think we can merge the two PRs.

stadlmax added 2 commits March 8, 2025 13:01
…s, fix handling of schwab sell orders with potentially different prices per event, get split data from yfinance instead of manually curated list
Copy link
Contributor

@szotsaki szotsaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newest version of YFinance is messy as it can be...

They removed session support, so you should remove it. However, they're adding it back in ranaroussi/yfinance#2505.

Then there are various other issues scattered around, like ranaroussi/yfinance#2474 which prevents stock splits retrieval, so this part of code wouldn't work anyhow.

It also complains about unset proxies, but it's just a warning: ranaroussi/yfinance#2512

I'll continue later.

Copy link
Contributor

@szotsaki szotsaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some minor issues on my side and adjusted better to the changed code.

Apart from these comments, I don't find anything else currently. I think the temporarily missing session handling can be solved by just removing the session parameter and as soon as it's back in YFinance, we can add it back here, too.

Everything else can be part of usual bug reports from wider audience :)

@stadlmax
Copy link
Owner Author

yfinance issues seems like a show-stopper for unfortunately

@stadlmax
Copy link
Owner Author

@szotsaki likely not nicely or over-engineered, but i revisited the historical prices through YF again

  • now with a manual and human-readable cache (i.e. in case YF breaks in the future again, it would be possible to potentially share or manually update some csv files)
  • tested things with more recent releases of YF (0.2.62/0.2.63) and things seem to work again

Copy link
Contributor

@szotsaki szotsaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes. I rebased #10, re-run the generator, and it worked the same as before :).

Let's merge!

(Ps. please merge my PR with the commit structure kept)

@stadlmax stadlmax merged commit 179b3a7 into main Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants