-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pingdom Transaction Checks #570
Merged
MuneebAijaz
merged 23 commits into
stakater:master
from
karlderkaefer:add-pingdom-transaction-checks
Jun 12, 2024
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
c0ca1e2
feat(pingdom): add post data field (#1)
karlderkaefer 6efde90
feat: add pingdom transaction checks
karlderkaefer 2c0ed34
feat: add pingdom transaction checks
karlderkaefer 24538dc
Merge branch 'master' into add-pingdom-transaction-checks
karlderkaefer 295032a
feat: generate crds
karlderkaefer eaf216e
feat: add mapping for step args
karlderkaefer 1e26926
feat: support multiple providers
karlderkaefer 43aac90
fix: optimize log outputs
karlderkaefer 3f1f566
fix: make test compability with macos arm64
karlderkaefer 2d24ee5
fix: update pingdom client to latest tag
karlderkaefer 0ef7381
fix: move util function to utils
karlderkaefer 38289cd
chore: go vet and go fmt
karlderkaefer b48165f
feat: update CRD for helm chart
karlderkaefer 6b72345
chore: reset helm chart spec
karlderkaefer 24c605b
fix: update golang client
karlderkaefer a834cea
docs: add readme for pingdom transaction
karlderkaefer 8dff896
chore: update crd
karlderkaefer d18cdc5
chore: update log output for pingdom
karlderkaefer 2f49d66
fix: logs need key pair values as input
karlderkaefer ff9d48e
feat: add secret template for sensitive data (#3)
karlderkaefer c06ff6e
fix: use helm compatible template for secrets
karlderkaefer 8e9a013
Merge branch 'master' into add-pingdom-transaction-checks
karlderkaefer 08fa1fd
chore: update go mod
karlderkaefer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -97,3 +97,4 @@ spec: | |
teamAlertContacts: "1234567_8_9-9876543_2_1,1234567_8_9-9876543_2_2" | ||
postDataEnvVar: "monitor-user" | ||
``` | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally would prefer a string array here because it's more natural for yaml and users. On the other hand, pingdom user might be used to existing format, What is your opinion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i myself prefer arrays as well for such conditions, pushed a change recently with array for grafana cloud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this requires a refactoring. The problem is the alertIntegration, alertContacts and TeamAlerts are defined in Provider struct
IngressMonitorController/pkg/config/config.go
Lines 65 to 67 in 88a3c47
This is used by all provider implementation. Probably string was used to allow more flexible setup and let the parsing upto the specific provider implementation.
I think its fine if we keep string here, also to align to existing pingdom configuration. I would like to do changes here