feat: add --ignore-annotation flag to override reloader.stakater.com/ignore#1146
Open
riptide-01 wants to merge 1 commit into
Open
feat: add --ignore-annotation flag to override reloader.stakater.com/ignore#1146riptide-01 wants to merge 1 commit into
riptide-01 wants to merge 1 commit into
Conversation
…ignore Allow users to customise the annotation key used to mark ConfigMaps and Secrets as ignored by Reloader, consistent with how every other annotation key is already overridable via a dedicated CLI flag. Changes: - internal/pkg/util/util.go: register --ignore-annotation persistent flag backed by options.IgnoreResourceAnnotation - deployments/kubernetes/chart/reloader/templates/deployment.yaml: pass --ignore-annotation when custom_annotations.ignore is set in Helm values - deployments/kubernetes/chart/reloader/values.yaml: document the new custom_annotations.ignore key in the example comment - README.md: add --ignore-annotation to the Annotation Key Overrides table and mention the flag alongside the Resource-Level Ignore Annotation section Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to customise the annotation key used to mark ConfigMaps and Secrets as ignored by Reloader, consistent with how every other annotation key is already overridable via a dedicated CLI flag.
Changes: