expose ipFamilies and ipFamilyPolicy for Service via helm values#1190
expose ipFamilies and ipFamilyPolicy for Service via helm values#1190sachinavina wants to merge 8 commits into
Conversation
|
@rasheedamir, @msafwankarim , I've submitted my first PR and would appreciate your review. Please let me know if there are any issues, improvements, or best practices I should incorporate. Looking forward to your feedback. Thank you! |
| {{ if .Values.reloader.service.ipFamilyPolicy -}} | ||
| ipFamilyPolicy: {{ .Values.reloader.service.ipFamilyPolicy }} | ||
| {{ end -}} | ||
| {{ if .Values.reloader.service.ipFamilies -}} | ||
| ipFamilies: {{ .Values.reloader.service.ipFamilies | toYaml | nindent 4 }} | ||
| {{ end -}} |
There was a problem hiding this comment.
Please verify if it works correctly and add helm tests for this. It looks like indentation can break this. The {{ if ... -}} / {{ end -}} trim markers strip the newline and leading indentation, ports: (and the ipFamily fields) land at the document root instead of under spec
There was a problem hiding this comment.
Fixed the indentation issue and added tests for the services resource. Please review
|
@msafwankarim , I have fixed the indentation issue and added tests for the services resource. Please take a look and let me know if any further changes are needed. |
2 participants
Fix for #1189