Add conflict retries#770
Closed
sthomson-wyn wants to merge 3 commits into
Closed
Conversation
- add conflict retries while upgrading items
Contributor
|
hi @sthomson-wyn can u pls look at the failing tests |
…into 766_retry # Conflicts: # internal/pkg/handler/upgrade.go
Author
|
@MuneebAijaz any guidance on running the tests locally? I'm just getting a timeout when running
|
Contributor
|
In what context are you running the tests locally? Do you have permission to create namespaces in that environment? Can you provide details about your local environment? |
Contributor
|
Thanks for your PR submission, apparantly conflict retries have been merged in #877. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #766