Enhance documentation and logging for label selector#927
Closed
tom1299 wants to merge 1 commit into
Closed
Conversation
tom1299
force-pushed
the
improve_selector_doc_and_logging
branch
from
34acccd to
7a185bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small improvement for the documentation and logging of the label selectors for namespaces and resources. Technically the values for
resource-label-selectorandnamespace-selectorare not comma separated list of label selectors but are in fact single selectors since they are directly passed as a selector in the controller