Fix colors remaining unchanged after custom theme #1867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue where after custom theme is once loaded, some colors will remain unchanged while switching to other themes
Contributor
Author
|
The fix now works fine but is more of a temporary one, so consider this WIP as I will work on a better solution. |
Contributor
Author
|
I've been informed that this PR tackles the same issue as #1852, making this a duplicate, while the changes are different. |
- Expose only `Load()` and `ThemeDict()` as public methods - `Load()` to trigger `theme.yaml` reload - `ThemeDict()` to return `ResourceDictionary` like other themes - Rewrite `App.axaml.cs` accordingly - Add `Name` and `IsDarkMode` properties to get info safely
Contributor
Author
|
Ended up rewriting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixed an issue regarding the custom theme feature implemented in #1821
After a custom theme is loaded, some colors will remain unchanged while switching back to other themes.
Details
Here, I first loaded the default "Custom YAML" theme (which is basically identical to the light theme).
Then, when I switch back to a different theme (I used dark theme to make it more obvious), some elements like the title bar or texts change color properly but others like the background color remains the same.
With this PR this will no longer be the case, and all the colors will change accordingly as determined by the themes.