Skip to content

chore: refactor github endpoints #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: refactor github endpoints #1193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c063fe9
github endpoints
fayekelmith Oct 12, 2025
23ed431
final test clean up
fayekelmith Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
233 changes: 60 additions & 173 deletions src/__tests__/integration/api/github-app-check.test.ts
View file
Open in desktop

Large diffs are not rendered by default.

252 changes: 65 additions & 187 deletions src/__tests__/integration/api/github-numofcommits.test.ts
View file
Open in desktop

Large diffs are not rendered by default.

287 changes: 92 additions & 195 deletions src/__tests__/integration/api/github-repository-permissions.test.ts
View file
Open in desktop

Large diffs are not rendered by default.

79 changes: 36 additions & 43 deletions src/__tests__/integration/api/github-users-search.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,12 @@ import { db } from "@/lib/db";
import { EncryptionService } from "@/lib/encryption";
import axios from "axios";
import {
createAuthenticatedSession,
mockUnauthenticatedSession,
expectSuccess,
expectUnauthorized,
expectError,
generateUniqueId,
getMockedSession,
createGetRequest,
createAuthenticatedGetRequest,
} from "@/__tests__/support/helpers";
import { createTestUser } from "@/__tests__/support/fixtures/user";

Expand Down Expand Up @@ -74,8 +72,6 @@ describe("GitHub Users Search API Integration Tests", () => {
test("should search GitHub users successfully with real database operations", async () => {
const { testUser, testAccount } = await createTestUserWithGitHubAccount();

getMockedSession().mockResolvedValue(createAuthenticatedSession(testUser));

// Mock GitHub API response
const mockGitHubResponse = {
data: {
Expand Down Expand Up @@ -103,7 +99,9 @@ describe("GitHub Users Search API Integration Tests", () => {

mockAxios.get.mockResolvedValue(mockGitHubResponse);

const request = createGetRequest("http://localhost:3000/api/github/users/search", { q: "john" });
const request = createAuthenticatedGetRequest("http://localhost:3000/api/github/users/search", testUser, {
q: "john",
});
const response = await GET(request);
const data = await expectSuccess(response);

Expand All @@ -113,19 +111,16 @@ describe("GitHub Users Search API Integration Tests", () => {
expect(data.total_count).toBe(2);

// Verify GitHub API was called with decrypted token
expect(mockAxios.get).toHaveBeenCalledWith(
"https://api.github.com/search/users",
{
headers: {
Authorization: "token github_pat_test_token",
Accept: "application/vnd.github.v3+json",
},
params: {
q: "john",
per_page: 10,
},
}
);
expect(mockAxios.get).toHaveBeenCalledWith("https://api.github.com/search/users", {
headers: {
Authorization: "token github_pat_test_token",
Accept: "application/vnd.github.v3+json",
},
params: {
q: "john",
per_page: 10,
},
});

// Verify real database lookup occurred
const accountInDb = await db.account.findFirst({
Expand All @@ -136,8 +131,6 @@ describe("GitHub Users Search API Integration Tests", () => {
});

test("should return 401 for unauthenticated user", async () => {
getMockedSession().mockResolvedValue(mockUnauthenticatedSession());

const request = createGetRequest("http://localhost:3000/api/github/users/search", { q: "john" });
const response = await GET(request);

Expand All @@ -147,9 +140,7 @@ describe("GitHub Users Search API Integration Tests", () => {
test("should return 400 for missing query parameter", async () => {
const { testUser } = await createTestUserWithGitHubAccount();

getMockedSession().mockResolvedValue(createAuthenticatedSession(testUser));

const request = createGetRequest("http://localhost:3000/api/github/users/search");
const request = createAuthenticatedGetRequest("http://localhost:3000/api/github/users/search", testUser);
const response = await GET(request);

await expectError(response, "Search query must be at least 2 characters", 400);
Expand All @@ -158,9 +149,9 @@ describe("GitHub Users Search API Integration Tests", () => {
test("should return 400 for query too short", async () => {
const { testUser } = await createTestUserWithGitHubAccount();

getMockedSession().mockResolvedValue(createAuthenticatedSession(testUser));

const request = createGetRequest("http://localhost:3000/api/github/users/search", { q: "a" });
const request = createAuthenticatedGetRequest("http://localhost:3000/api/github/users/search", testUser, {
q: "a",
});
const response = await GET(request);

await expectError(response, "Search query must be at least 2 characters", 400);
Expand All @@ -170,9 +161,11 @@ describe("GitHub Users Search API Integration Tests", () => {
// Create user without GitHub account
const userWithoutGitHub = await createTestUser({ name: "No Auth User" });

getMockedSession().mockResolvedValue(createAuthenticatedSession(userWithoutGitHub));

const request = createGetRequest("http://localhost:3000/api/github/users/search", { q: "john" });
const request = createAuthenticatedGetRequest(
"http://localhost:3000/api/github/users/search",
userWithoutGitHub,
{ q: "john" },
);
const response = await GET(request);

await expectError(response, "GitHub access token not found", 400);
Expand All @@ -181,14 +174,14 @@ describe("GitHub Users Search API Integration Tests", () => {
test("should return 401 for expired GitHub token", async () => {
const { testUser } = await createTestUserWithGitHubAccount();

getMockedSession().mockResolvedValue(createAuthenticatedSession(testUser));

// Mock GitHub API 401 response
mockAxios.get.mockRejectedValue({
response: { status: 401 },
});

const request = createGetRequest("http://localhost:3000/api/github/users/search", { q: "john" });
const request = createAuthenticatedGetRequest("http://localhost:3000/api/github/users/search", testUser, {
q: "john",
});
const response = await GET(request);

await expectError(response, "GitHub token expired or invalid", 401);
Expand All @@ -197,11 +190,11 @@ describe("GitHub Users Search API Integration Tests", () => {
test("should return 500 for other GitHub API errors", async () => {
const { testUser } = await createTestUserWithGitHubAccount();

getMockedSession().mockResolvedValue(createAuthenticatedSession(testUser));

mockAxios.get.mockRejectedValue(new Error("Network error"));

const request = createGetRequest("http://localhost:3000/api/github/users/search", { q: "john" });
const request = createAuthenticatedGetRequest("http://localhost:3000/api/github/users/search", testUser, {
q: "john",
});
const response = await GET(request);

await expectError(response, "Failed to search GitHub users", 500);
Expand All @@ -210,16 +203,16 @@ describe("GitHub Users Search API Integration Tests", () => {
test("should handle empty search results", async () => {
const { testUser } = await createTestUserWithGitHubAccount();

getMockedSession().mockResolvedValue(createAuthenticatedSession(testUser));

mockAxios.get.mockResolvedValue({
data: {
total_count: 0,
items: [],
},
});

const request = createGetRequest("http://localhost:3000/api/github/users/search", { q: "veryrareusername" });
const request = createAuthenticatedGetRequest("http://localhost:3000/api/github/users/search", testUser, {
q: "veryrareusername",
});
const response = await GET(request);
const data = await expectSuccess(response);

Expand All @@ -230,13 +223,13 @@ describe("GitHub Users Search API Integration Tests", () => {
test("should properly encrypt and decrypt access tokens", async () => {
const { testUser } = await createTestUserWithGitHubAccount();

getMockedSession().mockResolvedValue(createAuthenticatedSession(testUser));

mockAxios.get.mockResolvedValue({
data: { total_count: 0, items: [] },
});

const request = createGetRequest("http://localhost:3000/api/github/users/search", { q: "test" });
const request = createAuthenticatedGetRequest("http://localhost:3000/api/github/users/search", testUser, {
q: "test",
});
await GET(request);

// Verify the stored token is encrypted
Expand All @@ -255,7 +248,7 @@ describe("GitHub Users Search API Integration Tests", () => {
headers: expect.objectContaining({
Authorization: "token github_pat_test_token",
}),
})
}),
);
});
});
Expand Down
Loading
Loading