refactor: trying to simplify auth to remove an extra line we use on each route #1209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevkevinpal
force-pushed
the
simplifyAuth
branch
6 times, most recently
from
bb8ba70 to
8e0fb11
Compare
…wice in the route itself
kevkevinpal
force-pushed
the
simplifyAuth
branch
from
8e0fb11 to
14c0107
Compare
kevkevinpal
force-pushed
the
simplifyAuth
branch
from
09a058a to
74e5a37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we use
if (userOrResponse instanceof NextResponse) return userOrResponse;which seems a bit redundant since we can just throw an error in the auth check