-
Notifications
You must be signed in to change notification settings - Fork 5
Enhance devcontainer.json
handling with support for extensions, features, settings, and lifecycle commands
#8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@gonzaloaune Please review this PR. |
getting this in the logs upon starting a workspace:
|
git commit -m "Fix code-server container startup error with ENTRYPOINT format " git commit -m "Fix code-server container startup error with ENTRYPOINT format "
@gonzaloaune Done. |
@aliraza556 I don't think the solution is to find a random port but why is the 8443 used if it's supposed to be used for the code-server? |
@gonzaloaune Please review again: Fixed the port 8443 issue as requested. Instead of looking for alternative ports, the system now properly ensures code-server always uses port 8443 by terminating any conflicting processes. This matches our Service and Ingress configurations, resolving the connection issues. |
@aliraza556 still having problems, here are my logs:
as I said before, we shoudl find out the cause and not write code to circumvent the problem, 8443 should be the dedicated port for code-server, why is another process running there? Also how are you testing this? because you should be facing the same issues I'm facing. |
@aliraza556 I found the issue with the port, the nginx-ingress is using it for webhooks so it can;t be used (may have been a recent update to that pod) However I can't see the extensions installed even though the logs says they're installed, but upon checking the code-server they're not there |
Summary
This PR improves the handling of devcontainer.json configuration in workspace creation to provide full compatibility with GitHub Codespaces features. The implementation now properly detects, extracts, and processes all major elements from devcontainer.json files.
Changes
Added comprehensive parsing of devcontainer.json to extract:
Created robust helper scripts:
Improved Docker installation handling for different Linux distributions
Enhanced file handling with proper copying of all .devcontainer directory files
Added detailed logging throughout the process for better debugging
Closes: #3
Issue ticket number and link:
Bounty Link: