feat(casl-typeorm): add TypeORM integration#1172
Open
cookieMonsterDev wants to merge 3 commits intostalniy:masterfrom
Open
feat(casl-typeorm): add TypeORM integration#1172cookieMonsterDev wants to merge 3 commits intostalniy:masterfrom
cookieMonsterDev wants to merge 3 commits intostalniy:masterfrom
Conversation
Owner
|
Thanks for the PR. It will take some time to read through it and integrate it into existing ecosystem. For example, @ucast/sql has sub package for TypeORM. Which also supports joins on related records. https://github.com/stalniy/ucast/blob/master/packages/sql/src/lib/typeorm.ts Ucast/sql aims to provide low-level sql integration for all major SQL-* libs. This is easier from support perspective. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In work we use some weird integration that map mongoose to typeORM, so that is an opportunity to make official support for TypeORM. Feel free to change or improve this initial design.