Address parsing should succeed even when last '\n' is absent#136
Open
sftse wants to merge 4 commits intostalwartlabs:mainfrom
Open
Address parsing should succeed even when last '\n' is absent#136sftse wants to merge 4 commits intostalwartlabs:mainfrom
sftse wants to merge 4 commits intostalwartlabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been abusing the parsing routines of
mail-parserfor the parsing of parts of .msg messages, and the addresses there do not have terminating\n.Some tests seem to not care about the final
\n, but they are inconsistent about it, extending this to cover more cases seems in the spirit of prior tests.