Add Request::name() method returning SMTP command name#13
Open
edevil wants to merge 1 commit intostalwartlabs:mainfrom
Open
Add Request::name() method returning SMTP command name#13edevil wants to merge 1 commit intostalwartlabs:mainfrom
edevil wants to merge 1 commit intostalwartlabs:mainfrom
Conversation
Add a name() method to Request<T> that returns the SMTP command name as a &'static str (e.g. "EHLO", "MAIL", "RCPT", "QUIT"). This is useful for logging, tracing, and metrics where consumers need a human-readable label for the command variant. Currently every consumer has to write their own match expression for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
name()method toRequest<T>that returns the SMTP command name as a&'static str(e.g."EHLO","MAIL","RCPT","QUIT").This is useful for logging, tracing, and metrics where consumers need a human-readable label for the command variant. Currently every consumer of this crate has to write their own match expression to map request variants to command name strings — this is trivial boilerplate that belongs in the library.
Example
Changes
impl<T> Request<T>block withpub fn name(&self) -> &'static strinsrc/lib.rsrequest_nametest insrc/request/parser.rs