Open
Conversation
1 task
Author
|
@mdecimus could you have a look at this? It's a pretty small but very useful feature. |
Member
|
This needs to be gated as not everybody uses systemd or Linux. Also, see https://github.com/stalwartlabs/stalwart/blob/main/CONTRIBUTING.md as some contributions can't be accepted at this moment. |
Author
I would consider this change a very small and well-scoped change 🤔 IMO suppressing the errors functions well enough as gating, but I'll implement a proper check 👍 |
fe2c1d7 to
56a0bcf
Compare
Author
|
Now a check for systemd support is in place. |
Author
|
@mdecimus could you take another look? |
Member
|
Sorry, this can't be merged now. I suggest to run your own custom build in the meantime. |
This comment was marked as abuse.
This comment was marked as abuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #283
Allows a systemd service to use
Type=notify, so it's only considered ready once all the listeners are up.Additionally I also added sd_notify Reloading support, so systemd knows when stalwart is reloading the config due to an API call to the management API.
See https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html#Options and https://www.freedesktop.org/software/systemd/man/latest/sd_notify.html#Well-known%20assignments.