Sanitize whitespace in tmux session names#87
Open
kestermcullough wants to merge 1 commit intostandardagents:mainfrom
Open
Sanitize whitespace in tmux session names#87kestermcullough wants to merge 1 commit intostandardagents:mainfrom
kestermcullough wants to merge 1 commit intostandardagents:mainfrom
Conversation
Project paths containing spaces produced session names like 'dmux-my project-abcd1234' that broke chained tmux commands (e.g. set-option -t $sessionName ...) with 'too many arguments'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project paths containing spaces produced session names like
dmux-my project-abcd1234. Those names get interpolated unquoted into chained tmux commands inapplySessionPaneBorderOptions(e.g.tmux set-option -t ${sessionName} pane-border-status top \; set-option ...), which tmux then parses with extra tokens and aborts:Fix: replace any non-
[A-Za-z0-9_-]run with-when building the session identifier (a superset of the existing.sanitization).Repro:
mkdir "/tmp/foo bar" && cd "/tmp/foo bar" && git init && dmux(I ran into this problem while using WSL within Windows, on MacOS this did not occur with space names, FYI).