-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dependencies between pages on the wiki #43
Draft
robsimmons
wants to merge
6
commits into
main
Choose a base branch
from
web-of-knowledge
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsimmons
commented
Apr 18, 2024
Comment on lines
+32
to
+42
exec("node elf-watcher.mjs", { cwd: "../wiki/" }); | ||
const WIKI_TWELF_LOC = "../wiki/pages/"; | ||
const cfgs = []; | ||
for (const file of readdirSync(WIKI_TWELF_LOC)) { | ||
if (file.endsWith(".elf")) { | ||
if (file.endsWith(".cfg")) { | ||
const base = file.slice(0, file.length - 4); | ||
if (IGNORED_WIKI_FILES.has(base)) continue; | ||
const cfg = base + ".cfg"; | ||
writeFileSync(WIKI_TWELF_LOC + cfg, file); | ||
cfgs.push( | ||
`test${ | ||
UNSAFE_WIKI_FILES.has(base) ? "Unsafe" : "" | ||
} ${WIKI_TWELF_LOC}${cfg}` | ||
} ${WIKI_TWELF_LOC}${file}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the cfg auto-generation into the wiki project means we can just invoke that auto-generation to run the regression tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a feature I strongly resisted adding in the Mediawiki days, but I think the greatly simplified TwelfTag system we've got going makes it quite a bit more doable.
Also adds type-safety-for-the-stlc as a test of the feature. That file has the header
which causes all the Twelf code to be checked as if the contents of simply-typed-lambda-calculus.elf was included before the file. This has
#import
semantics from Objective-C, or#include
C preprocessor semantics where IFDEF is used correctly: multiple dependencies are allowed all transitive dependencies are included, but only once. This would allow there to be one file that contains natural numbers with no imports, a second file that decribes less-thanand a third file that describes addition
then, a fourth file could have the following imports
and
nat.elf
import is optional, because it will be included as a transitive dependencynat
which is only defined once, innat.elf
.