Skip to content

Conversation

@packagespace
Copy link

This allows to push auto-fixes to the branch instead of being in detached head state (closes #23)

I have tested my fork on one of my projects and I can confirm that it works.
However, there's a separate issue: the bot's commit and push trigger a new CI pipeline immediately, which can mask failures from later stages of the original user-initiated pipeline.

Try to get ref
Try without fetching all branches
@VikiAnn VikiAnn added the enhancement New feature or request label Jun 12, 2025
@jasonkarns
Copy link
Contributor

However, there's a separate issue: the bot's commit and push trigger a new CI pipeline immediately, which can mask failures from later stages of the original user-initiated pipeline.

Wouldn't the bot's commit also trigger those same downstream jobs? So if there was a failure in the original push, it would reoccur in the bot's push? (or it could be resolved, but either way, the status would be "correct")

uses: actions/checkout@v4

with:
ref: ${{ github.event.pull_request.head.ref }}
Copy link
Contributor

@jasonkarns jasonkarns Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't assume the event that started the job is a pull_request event. It could just as easily be a push event, workflow_dispatch, scheduled cron run, workflow_call, or something else entirely.

@jasonkarns
Copy link
Contributor

@packagespace did you intend to publish your fork to the marketplace? Would you consider renaming your fork so that the official action can be published under that name?

@packagespace
Copy link
Author

However, there's a separate issue: the bot's commit and push trigger a new CI pipeline immediately, which can mask failures from later stages of the original user-initiated pipeline.

Wouldn't the bot's commit also trigger those same downstream jobs? So if there was a failure in the original push, it would reoccur in the bot's push? (or it could be resolved, but either way, the status would be "correct")

As far as I remember, the bot's commit did not trigger the same jobs. I'm not using this on any project anymore but I've attached a screenshot of what happened.
image
As you can see, only the GitGuardian job was triggered. It could be that it just needs to be fixed with some configuration.

@packagespace did you intend to publish your fork to the marketplace? Would you consider renaming your fork so that the official action can be published under that name?

I've de-listed it, no idea publishing my fork would block anything from anyone else from being published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not able to push fixes from a pull request

3 participants