Skip to content

[audit] Fix fff.nvim PackChanged listener — use User autocmd pattern #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stanfish06 wants to merge 1 commit into from
Closed

[audit] Fix fff.nvim PackChanged listener — use User autocmd pattern #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lua/config/plugin_config.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,8 @@ end

-- fff
local fff_ok, _ = pcall(function()
vim.api.nvim_create_autocmd("PackChanged", {
vim.api.nvim_create_autocmd("User", {
pattern = "PackChanged",
Comment on lines +150 to +151

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore the PackChanged event for vim.pack hooks

When vim.pack installs or updates fff.nvim (for example through SyncPkgs), this autocmd now listens for the User event instead of the actual PackChanged event, so the callback will not run and the fff binary still will not be downloaded. I checked the current Neovim pack/autocmd docs: PackChanged and PackChangedPre are first-class autocmd events, and the documented hook example uses vim.api.nvim_create_autocmd('PackChanged', ...) with this same ev.data shape.

Useful? React with 👍 / 👎.

callback = function(ev)
local name, kind = ev.data.spec.name, ev.data.kind
if name == "fff.nvim" and (kind == "install" or kind == "update") then
Expand Down
Loading