[audit] Remove orphaned nvim-web-devicons entry from lock file#285
Merged
Conversation
nvim-web-devicons was dropped from package_list when mini.icons was added (mini_icons.mock_nvim_web_devicons() replaces the module). The lock file entry is now dead weight; removing it so vim.pack no longer tracks a package that is not managed. The installed pack directory (pack/plugins/start/nvim-web-devicons/) should also be deleted manually — its plugin/ scripts still run at startup alongside mini.icons, which is redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the stale
nvim-web-deviconsentry fromnvim-pack-lock.json.File:
nvim-pack-lock.json(lines 80–83 before this change)Why it matters
nvim-web-deviconswas removed frompackage_listinlua/config/plugins.luawhenmini.nvimwas added andmini_icons.mock_nvim_web_devicons()was set up to replace the module. However, the lock file entry was not cleaned up.Two consequences:
vim.packtracks a revision for a package it does not manage, which is confusing and could interfere with future lock file tooling.pack/plugins/start/nvim-web-devicons/directory still exists on disk (which it likely does, since:SyncPkgsonly removes packages in the list from the old dir), itsplugin/init scripts still run at Neovim startup alongside mini.icons.mini_icons.mock_nvim_web_devicons()replacespackage.loaded["nvim-web-devicons"]sorequire()calls return the mock, but the real plugin's highlight-group setup still executes redundantly.Recommended action
After merging, also delete the directory from your machine:
rm -rf ~/.config/nvim/pack/plugins/start/nvim-web-deviconsThen run
:SyncPkgs(or:PackerSyncif using the old path) to confirm the pack dir is clean.Generated by Claude Code