Skip to content

Fix GoogleSearch thread safety #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KrKOo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix GoogleSearch thread safety #351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion knowledge_storm/rm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1007,6 +1007,9 @@ def __init__(
super().__init__(k=k)
try:
from googleapiclient.discovery import build
from googleapiclient.http import HttpRequest
import httplib2

except ImportError as err:
raise ImportError(
"GoogleSearch requires `pip install google-api-python-client`."
Expand All @@ -1030,8 +1033,11 @@ def __init__(
else:
self.is_valid_source = lambda x: True

def build_request(http, *args, **kwargs):
return HttpRequest(httplib2.Http(), *args, **kwargs)

self.service = build(
"customsearch", "v1", developerKey=self.google_search_api_key
"customsearch", "v1", developerKey=self.google_search_api_key, requestBuilder=build_request
)
self.webpage_helper = WebPageHelper(
min_char_count=min_char_count,
Expand Down